Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general software profile example #78

Merged
merged 1 commit into from
May 21, 2024

Conversation

rnjudge
Copy link
Contributor

@rnjudge rnjudge commented May 1, 2024

This commit adds the software profile example drawio file and screenshot of the drawio diagram. The hope is that other profiles will build on top of this core example and we can generate SPDX docs for these examples to make adopting 3.0 easier.

@rnjudge
Copy link
Contributor Author

rnjudge commented May 1, 2024

cc @goneall

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rnjudge - could you add a brief README.md file in the example13 folder that explains the diagram?

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this example together!

Example looks good. Approving it for now.

Would it be possible to create a subsequent patch move example-13-spdx-3.json. to spdx-3.0/example3.

@rnjudge
Copy link
Contributor Author

rnjudge commented May 13, 2024

@kestewart I tried to move around the files in accordance with your suggestion for organization. Look ok?

@kestewart
Copy link
Contributor

Looks great Rose! Thank you.

Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are other issues with the JSON, we can fix them in a later PR.

software/example13/README.md Outdated Show resolved Hide resolved
software/example13/spdx-3.0/example-13-spdx-3.json Outdated Show resolved Hide resolved
This commit adds the software profile example drawio file and
screenshot of the drawio diagram. The hope is that other profiles will
build on top of this core example and we can generate SPDX docs for
these examples to make adopting 3.0 easier.

Signed-off-by: Rose Judge <[email protected]>
@goneall
Copy link
Member

goneall commented May 21, 2024

Based on @zvr comment above - I'll go ahead and merge

@goneall goneall merged commit 8a73b32 into spdx:master May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants