Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suite-sparse: add v7.4.0 #41738

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

suite-sparse: add v7.4.0 #41738

wants to merge 6 commits into from

Conversation

haampie
Copy link
Member

@haampie haampie commented Dec 18, 2023

Use the new cmake build system for suite sparse.

Pending DrTimothyAldenDavis/SuiteSparse#599

@spack spack deleted a comment from spackbot-app bot Dec 18, 2023
@alecbcs alecbcs changed the title suite-sparse: add 7.4.0 suite-sparse: add v7.4.0 Dec 18, 2023
@giordano giordano mentioned this pull request Dec 18, 2023
Merged
@giordano
Copy link
Member

The issue above was closed, all issues are reportedly addressed in v7.4.0

@mmuetzel
Copy link

Maybe, something like this is still missing?

        # 64bit blas in UMFPACK:
        if (
            spec.satisfies("^openblas+ilp64")
            or spec.satisfies("^intel-mkl+ilp64")
            or spec.satisfies("^intel-parallel-studio+mkl+ilp64")
        ):
            self.define("SUITESPARSE_USE_64BIT_BLAS", "ON")

Or whatever the correct syntax would be for that...

@haampie
Copy link
Member Author

haampie commented Jan 10, 2024

ilp64 and symbol_suffix are different things openblas +ilp64 symbol_suffix=64_. Have to check if they're separate supported or if the suffix is implied.

@mmuetzel
Copy link

ilp64 and symbol_suffix are different things openblas +ilp64 symbol_suffix=64_. Have to check if they're separate supported or if the suffix is implied.

If I understand the nomenclature here correctly, SUITESPARSE_USE_64BIT_BLAS corresponds to +ilp64.
symbol_suffix can be passed via BLAS64_SUFFIX, e.g., -DBLAS64_SUFFIX="_64".

@haampie
Copy link
Member Author

haampie commented Jan 10, 2024 •
edited
Loading

sigh, suite-sparses symbol suffix _64 is not consistent with openblas's symbol suffix 64_

@spackbot-app spackbot-app bot added the patch label Jan 10, 2024
mmuetzel
mmuetzel reviewed Jan 10, 2024
View reviewed changes
var/spack/repos/builtin/packages/suite-sparse/package.py
self.define("LAPACK_LIBRARIES", self.spec["lapack"].libs),
]

if blas.name == "openblas" and "symbol_suffix" in blas.variants:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only for OpenBLAS and not for any BLAS with a symbol suffix?
The "default" symbol suffix in SuiteSparse is no suffix at all.

@giordano giordano mentioned this pull request Mar 16, 2024
Merged
@bernhardkaindl bernhardkaindl mentioned this pull request Mar 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmuetzel mmuetzel mmuetzel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies libraries new-variant new-version patch update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haampie @giordano @mmuetzel