Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split OutlierDetectionStep into multiple steps #8634

Open
stscijgbot-jp opened this issue Jul 9, 2024 · 3 comments · May be fixed by #8722
Open

Split OutlierDetectionStep into multiple steps #8634

stscijgbot-jp opened this issue Jul 9, 2024 · 3 comments · May be fixed by #8722

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3682 was created on JIRA by Brett Graham:

The outlier detection step currently handles several different "modes" in sometimes very different ways:

  • imaging
  • spec
  • coron
  • tso
  • ifu

The docs mention that the parameters for the step are different depending on the mode:

https://jwst-pipeline.readthedocs.io/en/latest/jwst/outlier_detection/arguments.html

The step spec includes many items that are entirely unused in some modes (which is not fully documented).

These modes also expect very different input types and produce different results.

Different modes use different file suffixes, none of which are currently handled by the shared suffix machinery.

It seems reasonable that these should be split into different steps. However this will require:

  • new pars- references for the new steps
  • replacing pars-outlierdetectionstep
@stscijgbot-jp
Copy link
Collaborator Author

Comment by Ned Molter on JIRA:

I started looking into what is needed here on the cal side.  It looks like something we'd definitely like to do eventually, and I made a quick draft of what it might look like, which can be found in [this draft pull request|[https://github.com//pull/8722].]  However I sort of "jumped the gun" as this needs discussion with INS teams and would require parameter reference file changes, so assigning it to David again for input.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Initial discussion at the Sep 4 JP meeting; will be considered as part of possible 11.2 work.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Now that https://jira.stsci.edu/browse/JP-3347 is resolving without the need to use the IFU algorithm on FS/MOS data (which would have confused this effort significantly) I think we can unblock this.  I know at the same time work has been going on to reorganize the documentation, per https://jira.stsci.edu/browse/JP-3342

Tyler Pauly , pushing this back over to you.  Is this still desirable from your side based on the recent doc updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant