Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Create new key" option to key selection drop down in Create/Edit Account popup #82

Closed
monikasmolarek opened this issue Sep 10, 2024 · 2 comments · Fixed by #102
Closed
Labels
enhancement New feature or request

Comments

@monikasmolarek
Copy link
Collaborator

monikasmolarek commented Sep 10, 2024

As in the rec. Creating a new account will create a new record on the list, but it will be the same exact account. It's not only a displaying issue, the exported account files are also exactly the same. (as discussed - the reason behind it is that the account creation does not automatically create a new key for the account, it uses the existing key)

Screen.Recording.2024-09-10.at.12.41.37.mov
Screenshot 2024-09-10 at 12 53 59

I noticed the same while testing the deleting keys/accounts.
Delete Key- create a new key pair, you will get the exact same key over and over again.
I thought that it could be the cache issue? To be checked, I could easily reproduce it

cached.key.mov
@monikasmolarek monikasmolarek added the bug Something isn't working label Sep 10, 2024
@brusherru
Copy link
Member

It's not a bug. You are using the same key, and that's why you get the same address.

However, we may need to tweak GUI and show a messages like:

  • You already have such an account with the name "XXX"
  • or Some of your accounts already using this key (in case it is used in different account, but not the same as you're trying to create)

@brusherru
Copy link
Member

As we discussed on the call, I'll add "Create a new key" option to the dropdown and make it default (for SingleSig for sure).
Also I think that showing a message is still actual. So I'll add it as well.
Then I think it will be enough UX tweaks to not have confusion anymore. :)

@brusherru brusherru changed the title Create New Account or Key is generating the same addresses Add "Create new key" option to key selection drop down in Create/Edit Account popup Sep 16, 2024
@brusherru brusherru added enhancement New feature or request and removed bug Something isn't working labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants