Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Switch button when only one account exist #8

Closed
monikasmolarek opened this issue May 22, 2024 · 3 comments
Closed

Hide Switch button when only one account exist #8

monikasmolarek opened this issue May 22, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@monikasmolarek
Copy link
Collaborator

Once we create a new wallet, we have Account 0 and Account 1 automatically created
(was it only to test the "Switch" button? Don't forget to fix it back before release)

Screenshot 2024-05-22 at 21 43 08

@monikasmolarek monikasmolarek added the bug Something isn't working label May 22, 2024
@brusherru
Copy link
Member

Yeah, it was only to test path derivation and switch button out of the box, since there was no "create account" feature :)
It is fixed in #13

But probably I should also disable switch button in case there is only one account or add there an option "Create new account" 🤔

@monikasmolarek
Copy link
Collaborator Author

I would suggest hiding the button if only 1 account exists. The [create new account] option is in the settings and it's not something we need every day, so such a button might add unnecessary noise on this nice, minimalistic wallet screen. especially while using a smartphone

@brusherru brusherru changed the title Two Accounts created on new wallet setup Hide Switch button when only one account exist Jun 25, 2024
@brusherru brusherru added the enhancement New feature or request label Jun 26, 2024
@brusherru
Copy link
Member

This button were "merged" with the account name in the new design.
It is still possible to click on it and see that there is the only one account, but I think it is fine to allow get used to the UI even if User does not have more accounts.
I'm closing this issue for now. But if you think we need to improve something — let's open another one and write a proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants