Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch the ledger device connection and warn if lost #67

Closed
monikasmolarek opened this issue Aug 13, 2024 · 1 comment
Closed

Watch the ledger device connection and warn if lost #67

monikasmolarek opened this issue Aug 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@monikasmolarek
Copy link
Collaborator

Currently, Wallet doesn’t notice when the device is disconnected until the very last step of a device-related process.

The icon indicator also stays green showing the user that the ledger is still correctly connected, while in reality it might be unplugged.

To cover:

  • Verify the behavior after the Spacemesh App is closed on the ledger while it's still connected to the lite wallet app.
  • Verify the behavior after the ledger is locked (i.e. being idle) while it's still connected to the lite wallet app.
  • Verify the behavior after the ledger is unplugged while it's still connected to the lite wallet app.
@monikasmolarek monikasmolarek added the enhancement New feature or request label Aug 13, 2024
@brusherru
Copy link
Member

We cannot watch for the ledger device status, because it may corrupt interacting with the ledger device.

In details, we may watch for it's status only by calling some commands from time to time. However, Ledger device and it's interaction is synchronous, so if there will be any other command (e.g. some code triggered signing tx, while we're running another command to get a status) — both of them may fail. And even if we may solve this in out app by integrating mutex and some more complicated mechanisms, it still may break the whole UX when User will interact with other apps, having our wallet opened.

The good news, that if device is not connected anymore / locked / or app is closed — Wallet App will show a corresponding popup later when User will interact with it.

So I believe it does not make sense, and therefore I'm closing this issue.
If the indicator confuses User somehow – we may remove it, and keep all "connection" things right at the moment when User trying to interact with Ledger somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants