genvm.sdk.multisig.SelfSpawn takes wrong key type

[lrettig]

Description

This method takes pubs public keys as type ed25519.PublicKey:

go-spacemesh/genvm/sdk/multisig/tx.go

Lines 73 to 89 in 1be211b

	func SelfSpawn(
	ref uint8,
	pk ed25519.PrivateKey,
	template types.Address,
	required uint8,
	pubs []ed25519.PublicKey,
	nonce core.Nonce,
	opts ...sdk.Opt,
	) *Aggregator {
	args := multisig.SpawnArguments{Required: required}
	args.PublicKeys = make([]core.PublicKey, len(pubs))
	for i := range pubs {
	copy(args.PublicKeys[i][:], pubs[i])
	}
	principal := core.ComputePrincipal(template, &args)
	return Spawn(ref, pk, principal, template, &args, nonce, opts...)
	}

However, internally it immediately converts these keys to core.PublicKey. What's more, the spawn arguments for the same type require an array of core.PublicKey:

go-spacemesh/genvm/templates/multisig/types.go

Lines 13 to 17 in 1be211b

	// SpawnArguments contains a collection with PublicKeys.
	type SpawnArguments struct {
	Required uint8
	PublicKeys []core.PublicKey `scale:"max=10"` // update StorageLimit if it changes.
	}

Let's unify these types. SelfSpawn should probably take core.PublicKey.

This issue appears in commit hash: 1be211b

[dshulyak]

note that core.PublicKey is a 32 byte array, the reason why it is a an array is to avoid length prefixing every public key when encoding spawn arguments. obviously the same is true for decoding. this conversion is intentional.

ed25519.PublicKey is a slice, that doesn't do copy when passed around, and also every crypto library exposes public key as a slice, so it won't be convenient to do a cast to *[32]byte earlier.

i doubt that "unification" of types makes sense, it is better to close this issue

[lrettig]

This was inspired by spacemeshos/smcli#115 where I was confused and frustrated by the need to pass multiple key types in different places

[dshulyak]

is it because you had to use spawn arguments struct directly? and in addition to that used "sdk" API?
i looked at functions in sdk module and it doesn't accept core.PublicKey anywhere