-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle buf warnings for streaming methods http rules #150
Comments
The json gateway should be able to support the streaming endpoints. But I don't think we've ever tested this. I'm disinclined to add them since we should generally discourage use of the json gateway in favor of the underlying grpc endpoints. |
Okay - so the question is why do we support json/http at all, even for the non-streaming endpoints? |
I've seen the CI code in the IMO, it's better to remove the json endpoints. |
I see no reason to keep them in the node level for 0.3 and I agree that we should better remove them so no new code relies on them. |
I don't have a strong opinion here. There's already support for the json gateway in the node, so I'm inclined to leave it there. Just have it off by default. |
I think we should get rid of the http-json gateway altogether and this will resolve this issue. See #151 |
Currently, there are no http rules for the streaming methods. These rules are used to generate the gateway json api.
A bit of research is needed hre- can thegateway json api support Spacemesh streaming grpc methods? if yes - update the rules to include the streaming methods. If not - remove the build warnings about missing streaming methods.
@daonb @lrettig
The text was updated successfully, but these errors were encountered: