Skip to content
GitHub Actions / clippy succeeded Nov 17, 2023 in 0s

clippy

9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 9
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad46 2023-10-03)

Annotations

Check warning on line 109 in core/src/api/search/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference

warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
   --> core/src/api/search/utils.rs:109:3
    |
109 |         self,
    |         ^^^^
    |
    = help: consider choosing a less ambiguous name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention

Check warning on line 75 in core/src/api/search/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference

warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
  --> core/src/api/search/utils.rs:75:3
   |
75 |         self,
   |         ^^^^
   |
   = help: consider choosing a less ambiguous name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
   = note: `#[warn(clippy::wrong_self_convention)]` on by default

Check warning on line 146 in core/src/api/search/saved.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

warning: used `unwrap()` on a `Result` value
   --> core/src/api/search/saved.rs:146:31
    |
146 |                         let filters_as_string = serde_json::to_string(filters).unwrap();
    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 117 in core/src/api/search/saved.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

warning: used `unwrap()` on a `Result` value
   --> core/src/api/search/saved.rs:117:34
    |
117 |                         let filters: Vec<Filter> = serde_json::from_str(&filters_string).unwrap();
    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 116 in core/src/api/search/saved.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

warning: used `unwrap()` on a `Result` value
   --> core/src/api/search/saved.rs:116:28
    |
116 |                         let filters_string = String::from_utf8(filters_bytes).unwrap();
    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 54 in core/src/api/search/saved.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value

warning: used `unwrap()` on a `Result` value
  --> core/src/api/search/saved.rs:54:17
   |
54 | ...                   .map(|f| serde_json::to_string(&f).unwrap().into_bytes())
   |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: if this value is an `Err`, it will panic
   = help: consider using `expect()` to provide a better panic message
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
  --> core/src/lib.rs:1:9
   |
1  | #![warn(clippy::unwrap_used, clippy::panic)]
   |         ^^^^^^^^^^^^^^^^^^^

Check warning on line 36 in core/src/api/search/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `into_prisma` is never used

warning: method `into_prisma` is never used
  --> core/src/api/search/utils.rs:36:9
   |
35 | impl<T> MaybeNot<T> {
   | ------------------- method in this implementation
36 |     pub fn into_prisma<R: From<prisma_client_rust::Operator<R>>>(self, param: fn(T) -> R) -> R {
   |            ^^^^^^^^^^^

Check warning on line 69 in core/src/api/search/saved.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `mount` is never used

warning: function `mount` is never used
  --> core/src/api/search/saved.rs:69:15
   |
69 | pub(crate) fn mount() -> AlphaRouter<Ctx> {
   |               ^^^^^

Check warning on line 38 in core/src/api/search/saved.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `exec` is never used

warning: method `exec` is never used
  --> core/src/api/search/saved.rs:38:15
   |
37 | impl SavedSearchCreateArgs {
   | -------------------------- method in this implementation
38 |     pub async fn exec(
   |                  ^^^^
   |
   = note: `#[warn(dead_code)]` on by default