Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize and clean up internationalization file keys #2741

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

iLynxcat
Copy link
Member

@iLynxcat iLynxcat commented Sep 29, 2024

Lots of files were ordered wrong, had uppercase/inconsistent key names, overall the whole thing was a mess. We should probably put something in place to ensure these don't get messed up like this again but probably not worth the time and effort at this exact moment

Having files formatted wrong makes editing translations via i18n Ally a pain since the extension reformats everything every time you make an edit within the extension

Closes ENG-1922

@iLynxcat iLynxcat requested a review from a team as a code owner September 29, 2024 06:42
Copy link

vercel bot commented Sep 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 6:43am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 6:43am

Copy link

linear bot commented Sep 29, 2024

Copy link
Member

@Rocky43007 Rocky43007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rocky43007 Rocky43007 added this pull request to the merge queue Sep 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2024
@iLynxcat iLynxcat added this pull request to the merge queue Sep 29, 2024
Merged via the queue into main with commit a0173ca Sep 29, 2024
11 checks passed
@iLynxcat iLynxcat deleted the organize-i18n-keys branch September 29, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants