Add no telemetry option and improve analytics code clarity #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` instead of `initPlausible` for improved clarity
if any people reviewing source for their own verification of its purpose, this should make it much clearer what this does
changing the option in the Select dropdown breaks things right now, gotta figure out why
… to submitPlausibleEvent
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
iLynxcat
changed the title
|
Just need to polish UI for this and should be good to go after! |
|
Need to change cypress onboarding test here to add the new telemetry option and rename the element ids: spacedrive/apps/web/cypress/e2e/1-onboarding.spec.cy.ts Lines 133 to 139 in a0173ca |
|
Also just remembered I need to figure out how to properly migrate the old telemetry preference to this new property format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily aimed at adding a "none" option for analytics which has been highly requested, with some other related changes to help improve clarity of some of our analytics functionality for people who may be reviewing the code for their own peace of mind.