Update pdfium-render version #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matheus-consoli
commented
Sep 11, 2024
This reverts commit 1c84e23.
- Bump the minimum pdfium lib api version (updated bundled lib in native-deps) - Custom fork is still required because upstream added a hard limit on chono version 0.4.31, which is incompatible with some of our dependencies which require newer versions
HeavenVolkoff
force-pushed
the
pdfium-render-revert-and-bump
branch
from
8d172d2
to
cb1a144
Compare
HeavenVolkoff
changed the title
HeavenVolkoff
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
LGTM, @matheus-consoli can you test again just to make sure it is working for you too
Edit: No ideia why ESLint CI failed, some weird error during setup, will probably pass after a re-run
|
working perfectly, thanks @HeavenVolkoff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R̶e̶v̶e̶r̶t̶ ̶#̶2̶6̶6̶6̶ ̶a̶n̶d̶ ̶b̶u̶m̶p̶ ̶p̶d̶f̶i̶u̶m̶-̶r̶e̶n̶d̶e̶r̶ ̶v̶e̶r̶s̶i̶o̶n̶.̶
W̶i̶t̶h̶ ̶o̶u̶r̶ ̶c̶u̶r̶r̶e̶n̶t̶ ̶f̶o̶r̶k̶,̶ ̶w̶e̶ ̶r̶e̶c̶e̶i̶v̶e̶ ̶a̶ ̶l̶o̶t̶ ̶o̶f̶ ̶e̶r̶r̶o̶r̶s̶ ̶r̶e̶l̶a̶t̶e̶d̶ ̶t̶o̶ ̶l̶i̶n̶k̶i̶n̶g̶,̶ ̶a̶n̶d̶ ̶t̶h̶e̶ ̶o̶r̶i̶g̶i̶n̶a̶l̶ ̶c̶r̶a̶t̶e̶ ̶m̶e̶r̶g̶e̶d̶ ̶o̶u̶r̶ ̶c̶h̶a̶n̶g̶e̶s̶ ̶(̶t̶h̶a̶n̶k̶s̶ ̶@̶H̶e̶a̶v̶e̶n̶V̶o̶l̶k̶o̶f̶f̶!̶)̶
@HeavenVolkoff: Updated custom fork and increased the minimum required pdfium api, now that native_deps ships the latest pdfium lib. Unfortunately, we still need a custom fork due to upstream adding a hard limit on chono version <= 0.4.31, which is incompatible with some of our dependencies which require newer versions