Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-1838] Fix Debian executable name #2648

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[ENG-1838] Fix Debian executable name #2648

merged 1 commit into from
Jul 30, 2024

Conversation

HeavenVolkoff
Copy link
Member

Workaround tauri using cargo.toml name for executable when packaging .deb

Closes: #2647

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 10:02pm
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 10:02pm

@linear Linear
Copy link

linear bot commented Jul 30, 2024

ENG-1838 spacedrive.desktop refers to sd-desktop which is missing

@HeavenVolkoff HeavenVolkoff marked this pull request as draft July 30, 2024 22:07
@iLynxcat iLynxcat changed the title [ENG-1838] Fix .desktop incorrect executable name [ENG-1838] Fix Debian executable name Jul 30, 2024
@HeavenVolkoff
Copy link
Member Author

PR will stay a draft while release doesn't finish building:
https://github.com/spacedriveapp/spacedrive/actions/runs/10170447287

@HeavenVolkoff HeavenVolkoff marked this pull request as ready for review July 30, 2024 23:03
@HeavenVolkoff
Copy link
Member Author

Ci finished, .desktop file in new release is fixed. 0.4.1 release .deb was replaced with the fixed one

@HeavenVolkoff HeavenVolkoff added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit df8669c Jul 30, 2024
16 checks passed
@HeavenVolkoff HeavenVolkoff deleted the fix-desktop-file branch July 30, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriewong052 valeriewong052 valeriewong052 approved these changes

@fogodev fogodev Awaiting requested review from fogodev

@matheus-consoli matheus-consoli Awaiting requested review from matheus-consoli

@jamiepine jamiepine Awaiting requested review from jamiepine

@iLynxcat iLynxcat Awaiting requested review from iLynxcat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debian package references incorrect executable name
3 participants
@HeavenVolkoff @valeriewong052 @greendoescode