Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP control fuzzing and bugfixes #24

Merged
merged 9 commits into from
May 27, 2024
Merged

TCP control fuzzing and bugfixes #24

merged 9 commits into from
May 27, 2024

Conversation

soypat
Copy link
Owner

@soypat soypat commented May 27, 2024

Added:

  • Fuzz test for ControlBlock segment generation and acceptance, both incoming and outgoing.
  • Added StringExchange package level function
  • Created seqs.go to store common logic and types
  • Added Fuzz test for stacks.TCPConn type, closing the testing loop for communications between client and server with packet length randomness.
  • Add bugfixes for zero window size control flow.
  • Now correctly calculates outgoing packet length maximum basing itself on UNA, NXT and Window size

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 45.99%. Comparing base (a6350ce) to head (d92791d).
Report is 1 commits behind head on main.

Files Patch % Lines
seqs.go 74.00% 25 Missing and 1 partial ⚠️
control.go 51.61% 14 Missing and 1 partial ⚠️
control_user.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   45.25%   45.99%   +0.74%     
==========================================
  Files          28       29       +1     
  Lines        4872     4937      +65     
==========================================
+ Hits         2205     2271      +66     
- Misses       2405     2406       +1     
+ Partials      262      260       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soypat
Copy link
Owner Author

soypat commented May 27, 2024

Tested with cyw43439, http-server example and seems to work perfectly.

@soypat soypat merged commit 1201bab into main May 27, 2024
3 checks passed
@soypat soypat deleted the action-fuzz branch May 27, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant