Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test replicating panic encountered by @knieriem in #19 #21

Merged
merged 2 commits into from
May 7, 2024

Conversation

soypat
Copy link
Owner

@soypat soypat commented May 5, 2024

Resolves #19.

First commit is failing commit showing issue reproduction in a test.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 45.29%. Comparing base (bde06f1) to head (e4c5683).

Files Patch % Lines
control_user.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   44.68%   45.29%   +0.61%     
==========================================
  Files          28       28              
  Lines        4852     4857       +5     
==========================================
+ Hits         2168     2200      +32     
+ Misses       2419     2395      -24     
+ Partials      265      262       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soypat
Copy link
Owner Author

soypat commented May 7, 2024

Alright, merging since @knieriem tested!

@soypat soypat merged commit d1b5854 into main May 7, 2024
3 checks passed
@soypat soypat deleted the wget-panic branch May 7, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected stateClosing during HTTP request using wget
1 participant