Dev containers & GHA Release Flow #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
pSchlarb
force-pushed
the
DevContainers
branch
2 times, most recently
from
263ef5d
to
e5e7a68
Compare
pSchlarb
commented
Jan 10, 2023
WadeBarnes
requested changes
Jan 10, 2023
|
Added a ticket for future enhancements; #312 |
WadeBarnes
reviewed
Jan 11, 2023
Signed-off-by: pSchlarb <[email protected]>
Devcontainer fix Signed-off-by: Philipp Schlarb <[email protected]>
Signed-off-by: pSchlarb <[email protected]>
Signed-off-by: pSchlarb <[email protected]> removal of repo components Signed-off-by: Philipp Schlarb <[email protected]> updated token version Signed-off-by: Philipp Schlarb <[email protected]> keyserver fix Signed-off-by: pSchlarb <[email protected]>
- indy-test-automation workflow was updated to exclude them by default. Signed-off-by: Wade Barnes <[email protected]> (cherry picked from commit c10015b) Signed-off-by: pSchlarb <[email protected]>
Signed-off-by: pSchlarb <[email protected]> fixed case sensitive reference Signed-off-by: pSchlarb <[email protected]>
pSchlarb
force-pushed
the
DevContainers
branch
from
d404e48
to
8481dd9
Compare
Signed-off-by: pSchlarb <[email protected]>
pSchlarb
force-pushed
the
DevContainers
branch
2 times, most recently
from
95fdf33
to
efde62b
Compare
Signed-off-by: pSchlarb <[email protected]>
pSchlarb
force-pushed
the
DevContainers
branch
from
efde62b
to
e99aec8
Compare
WadeBarnes
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Looks good. The build failures are expected due to the permissions on PRs. The DinD image is not being pushed to the repo's image repository. It's passing because it's not trying to push the image. The client build is failing because the image does not exist yet (expected, will be there once PR is merged).
Just waiting to see the results on https://github.com/pSchlarb/sovrin/actions/runs/3894517829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.