You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the addition of input + new matrix is included, while the addition in mat1 @ mat2 seems not been considered
assume mat1 and mat2 have shape m*n and n*l, the total operation output for addmm will be m*n*l+m*l, but I think it might be m*n*l+(n-1)*m*l+m*l=2*m*n*l
I understand that addition might affect little to the total process, but maybe a constant regulation for computing will be more reasonable? Or is there any error in my expression, like in real case we could have some extra condition?
Thank you very much
The text was updated successfully, but these errors were encountered:
After going through the source code, I found that in different func the addition operation is count in different style
in torch.add all addition seems to be counted
while in some matrices multiplication, part of the addition is not
one example is in torch,addmm,
input + mat1 @ mat2
the addition of
input + new matrix
is included, while the addition inmat1 @ mat2
seems not been consideredassume mat1 and mat2 have shape m*n and n*l, the total operation output for addmm will be
m*n*l+m*l
, but I think it might bem*n*l+(n-1)*m*l+m*l=2*m*n*l
I understand that addition might affect little to the total process, but maybe a constant regulation for computing will be more reasonable? Or is there any error in my expression, like in real case we could have some extra condition?
Thank you very much
The text was updated successfully, but these errors were encountered: