Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix english I18n strings & externalize all strings #828

Open
9 tasks
Tracked by #829
richardtreier opened this issue Sep 16, 2024 · 0 comments
Open
9 tasks
Tracked by #829

fix english I18n strings & externalize all strings #828

richardtreier opened this issue Sep 16, 2024 · 0 comments
Assignees
Labels
kind/enhancement New feature or request

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented Sep 16, 2024

The PR #756 introduced i18n:

  • The PR was alive too long.
  • Translation required the SharedModule refactoring that was prepared.
  • Any changes were merge conflicts, especially wording changes.

Thus we need to properly check the UIs now, @illfixit

  • Check the fast-tracked PR for open discussions
  • Some english translations are missing after the merging
  • All pages need to be eyeballed for missed wording changes that @richardtreier might have missed resolving merge conflicts
  • All strings added in changes between need to be extracted (See https://github.com/thiagocordeirooo/generate-translation-vscode)
  • Ignore the german translation until we have collected all keys (separate issue)
  • Consider transforming the keys into a format they can be found with Ctrl+F (no points)
  • Consider moving keys where they belong, e.g. splitting Asset List Page and Asset Metadata
@richardtreier richardtreier added the kind/enhancement New feature or request label Sep 16, 2024
@richardtreier richardtreier changed the title Fix English I18n Strings Fix English I18n Strings & Externalize all strings Sep 16, 2024
@richardtreier richardtreier changed the title Fix English I18n Strings & Externalize all strings fix english I18n strings & externalize all strings Sep 16, 2024
@illfixit illfixit self-assigned this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants