Update Dockerfile #445
Closed
Update Dockerfile #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sybereal
requested changes
Jul 24, 2023
|
|
||
| ARG BUILD_ARGS | ||
|
|
||
| COPY --chown=gradle:gradle . /home/gradle/project/ | ||
| WORKDIR /home/gradle/project/ | ||
| RUN --mount=type=cache,target=/home/gradle/.gradle/caches gradle build --no-daemon $BUILD_ARGS | ||
|
|
||
| # -buster is required to have apt available | ||
| FROM openjdk:17-slim-buster | ||
| FROM eclipse-temurin:17-alpine |
There was a problem hiding this comment.
Suggested change
| FROM eclipse-temurin:17-alpine | |
| FROM eclipse-temurin:17-jre-alpine |
The runtime layer shouldn't need a full JDK. Reduces base image size from ~200 MB to ~50 MB.
Comment on lines
+21
to
23
| RUN apk update \ | ||
| && apk add curl \ | ||
| && rm -rf /var/cache/apt/archives /var/lib/apt/lists \ |
There was a problem hiding this comment.
Suggested change
| RUN apk update \ | |
| && apk add curl \ | |
| && rm -rf /var/cache/apt/archives /var/lib/apt/lists \ | |
| RUN apk add --no-cache curl \ |
| @@ -19,8 +18,8 @@ ENV EDC_BUILD_DATE=$EDC_BUILD_DATE_ARG | |||
| ARG JVM_ARGS="" | |||
|
|
|||
| # Install curl, then delete apt indexes to save image space | |||
There was a problem hiding this comment.
Suggested change
| # Install curl, then delete apt indexes to save image space |
|
Closed in favor of #450 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.