-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify EvaluationContext
with regards to evaluation tracking
#18
Conversation
dbc30dc
to
f0933ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: 23760c3 | Previous: 03841f2 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
2738368958.000024 ns/iter |
2839408292.00003 ns/iter |
0.96 |
Evaluator_Draft4_Meta_1_No_Callback |
743.2476629697161 ns/iter |
743.5469590861595 ns/iter |
1.00 |
Evaluator_Draft4_Required_Properties |
924.8174597203961 ns/iter |
923.5978188797426 ns/iter |
1.00 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
149.70578334494445 ns/iter |
149.4064550628632 ns/iter |
1.00 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
101.66244092004492 ns/iter |
101.3915693257818 ns/iter |
1.00 |
Evaluator_Draft4_Items_Schema |
2630.648972589678 ns/iter |
2610.7580294881486 ns/iter |
1.01 |
Evaluator_Draft4_Nested_Object |
21.582702382860557 ns/iter |
21.71149052074103 ns/iter |
0.99 |
Evaluator_Draft4_Properties_Triad_Optional |
1261.364808824731 ns/iter |
1261.668232284767 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Closed |
956.1366833267784 ns/iter |
959.7799140351937 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Required |
1289.4372136255545 ns/iter |
1290.1197895142004 ns/iter |
1.00 |
Evaluator_Draft4_Non_Recursive_Ref |
210.9739785696166 ns/iter |
214.04803281972937 ns/iter |
0.99 |
Evaluator_Draft4_Pattern_Properties_True |
1338.8865911924563 ns/iter |
1344.5487921371168 ns/iter |
1.00 |
Evaluator_Draft4_Ref_To_Single_Property |
104.11270846675903 ns/iter |
104.69173028271494 ns/iter |
0.99 |
Evaluator_Draft4_Additional_Properties_Type |
404.5636835268516 ns/iter |
407.8956475719329 ns/iter |
0.99 |
Evaluator_Draft4_Nested_Oneof |
364.4159013307927 ns/iter |
364.4388417480949 ns/iter |
1.00 |
Evaluator_Draft6_Property_Names |
822.318965031793 ns/iter |
765.1850988491556 ns/iter |
1.07 |
Evaluator_Draft7_If_Then_Else |
166.87448337121188 ns/iter |
166.7528249871194 ns/iter |
1.00 |
Evaluator_2019_09_Unevaluated_Properties |
630.4896401143424 ns/iter |
626.7118433538344 ns/iter |
1.01 |
Evaluator_2020_12_Dynamic_Ref |
1403.901094263564 ns/iter |
1415.1006504835768 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: 23760c3 | Previous: 03841f2 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
5179316679.999999 ns/iter |
5312041257.999965 ns/iter |
0.98 |
Evaluator_Draft4_Meta_1_No_Callback |
982.5992275703026 ns/iter |
976.962994252921 ns/iter |
1.01 |
Evaluator_Draft4_Required_Properties |
1659.5861936191702 ns/iter |
1538.3553180559804 ns/iter |
1.08 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
175.7886608387191 ns/iter |
180.20887722791045 ns/iter |
0.98 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
126.32744803533512 ns/iter |
125.40850478904697 ns/iter |
1.01 |
Evaluator_Draft4_Items_Schema |
3531.146669438335 ns/iter |
3447.703874270222 ns/iter |
1.02 |
Evaluator_Draft4_Nested_Object |
29.73115907373672 ns/iter |
30.40355127405485 ns/iter |
0.98 |
Evaluator_Draft4_Properties_Triad_Optional |
1804.323880232153 ns/iter |
1825.0001579168922 ns/iter |
0.99 |
Evaluator_Draft4_Properties_Triad_Closed |
1503.0084644860165 ns/iter |
1504.3774964073518 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Required |
1896.6925964702846 ns/iter |
1895.5309399813377 ns/iter |
1.00 |
Evaluator_Draft4_Non_Recursive_Ref |
475.65653566283663 ns/iter |
501.2597759999835 ns/iter |
0.95 |
Evaluator_Draft4_Pattern_Properties_True |
2486.1030808633413 ns/iter |
2475.3062445093465 ns/iter |
1.00 |
Evaluator_Draft4_Ref_To_Single_Property |
155.4536649145181 ns/iter |
128.5379325277329 ns/iter |
1.21 |
Evaluator_Draft4_Additional_Properties_Type |
595.250201356884 ns/iter |
601.8132539636097 ns/iter |
0.99 |
Evaluator_Draft4_Nested_Oneof |
458.76131523536105 ns/iter |
468.10429557249023 ns/iter |
0.98 |
Evaluator_Draft6_Property_Names |
1256.9300724584896 ns/iter |
1248.1886003728462 ns/iter |
1.01 |
Evaluator_Draft7_If_Then_Else |
201.27867629320474 ns/iter |
203.40568526550476 ns/iter |
0.99 |
Evaluator_2019_09_Unevaluated_Properties |
782.0033594110836 ns/iter |
729.8286515781604 ns/iter |
1.07 |
Evaluator_2020_12_Dynamic_Ref |
1854.4598528801262 ns/iter |
1852.845747525499 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti <[email protected]>
f0933ca
to
23760c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: 23760c3 | Previous: 03841f2 | Ratio |
---|---|---|---|
Evaluator_2020_12_Dynamic_Ref |
1824.3176241783615 ns/iter |
1893.9069164126724 ns/iter |
0.96 |
Evaluator_2019_09_Unevaluated_Properties |
771.0954968338427 ns/iter |
761.9466365168186 ns/iter |
1.01 |
Evaluator_Draft7_If_Then_Else |
198.53645361248428 ns/iter |
204.86394079383177 ns/iter |
0.97 |
Evaluator_Draft6_Property_Names |
1635.28841127273 ns/iter |
1651.338962460647 ns/iter |
0.99 |
Evaluator_Draft4_Meta_1_No_Callback |
1078.6924155291215 ns/iter |
1119.6097461523282 ns/iter |
0.96 |
Evaluator_Draft4_Required_Properties |
2216.3547275686396 ns/iter |
2323.813789417433 ns/iter |
0.95 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
195.78563645908974 ns/iter |
194.22540418070145 ns/iter |
1.01 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
135.99524388442842 ns/iter |
139.1652146244282 ns/iter |
0.98 |
Evaluator_Draft4_Items_Schema |
3081.522985598487 ns/iter |
3208.7249346238277 ns/iter |
0.96 |
Evaluator_Draft4_Nested_Object |
23.92496406143852 ns/iter |
24.890109165051207 ns/iter |
0.96 |
Evaluator_Draft4_Properties_Triad_Optional |
1680.0444432192699 ns/iter |
1758.1677140407264 ns/iter |
0.96 |
Evaluator_Draft4_Properties_Triad_Closed |
1389.6723584879148 ns/iter |
1444.7355052536748 ns/iter |
0.96 |
Evaluator_Draft4_Properties_Triad_Required |
1754.905927828562 ns/iter |
1832.3017435533009 ns/iter |
0.96 |
Evaluator_Draft4_Non_Recursive_Ref |
459.1036670434844 ns/iter |
486.16827942055386 ns/iter |
0.94 |
Evaluator_Draft4_Pattern_Properties_True |
2270.108274473884 ns/iter |
2337.6070525096043 ns/iter |
0.97 |
Evaluator_Draft4_Ref_To_Single_Property |
142.97491630496117 ns/iter |
147.6347204657246 ns/iter |
0.97 |
Evaluator_Draft4_Additional_Properties_Type |
1086.8563451942362 ns/iter |
1125.378062157277 ns/iter |
0.97 |
Evaluator_Draft4_Nested_Oneof |
459.3440029505597 ns/iter |
469.3795976636142 ns/iter |
0.98 |
Compiler_Draft6_AdaptiveCard |
5776522263.000004 ns/iter |
5686618487.000032 ns/iter |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/gcc)
Benchmark suite | Current: 23760c3 | Previous: 03841f2 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
4131822824.4781494 ns/iter |
4349333047.866821 ns/iter |
0.95 |
Evaluator_Draft4_Meta_1_No_Callback |
815.0164355680598 ns/iter |
824.2729610195024 ns/iter |
0.99 |
Evaluator_Draft4_Required_Properties |
1068.2337845180573 ns/iter |
1102.9721965472866 ns/iter |
0.97 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
186.2678615529944 ns/iter |
185.19849145398737 ns/iter |
1.01 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
127.59918868430488 ns/iter |
127.44878190274383 ns/iter |
1.00 |
Evaluator_Draft4_Items_Schema |
2565.053036031827 ns/iter |
2540.025044405515 ns/iter |
1.01 |
Evaluator_Draft4_Nested_Object |
26.948088639026423 ns/iter |
27.16742640951988 ns/iter |
0.99 |
Evaluator_Draft4_Properties_Triad_Optional |
1613.8084178785684 ns/iter |
1618.232110922954 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Closed |
1389.4901376261691 ns/iter |
1384.6925809804832 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Required |
1679.7136086752814 ns/iter |
1793.5504336890617 ns/iter |
0.94 |
Evaluator_Draft4_Non_Recursive_Ref |
449.2147833948807 ns/iter |
462.7375833827369 ns/iter |
0.97 |
Evaluator_Draft4_Pattern_Properties_True |
2155.7498159136144 ns/iter |
2170.0137005585984 ns/iter |
0.99 |
Evaluator_Draft4_Ref_To_Single_Property |
127.76997745600623 ns/iter |
129.60383155083358 ns/iter |
0.99 |
Evaluator_Draft4_Additional_Properties_Type |
503.48271902191306 ns/iter |
519.4129437461677 ns/iter |
0.97 |
Evaluator_Draft4_Nested_Oneof |
391.73369932725615 ns/iter |
414.72719848182925 ns/iter |
0.94 |
Evaluator_Draft6_Property_Names |
981.0057007771221 ns/iter |
1002.1202792670946 ns/iter |
0.98 |
Evaluator_Draft7_If_Then_Else |
194.9264032721022 ns/iter |
199.22554879941458 ns/iter |
0.98 |
Evaluator_2019_09_Unevaluated_Properties |
667.5167878099235 ns/iter |
702.0660928807495 ns/iter |
0.95 |
Evaluator_2020_12_Dynamic_Ref |
1699.361986924734 ns/iter |
1711.854724825968 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: 23760c3 | Previous: 03841f2 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
10357597700.000042 ns/iter |
10607396200.00004 ns/iter |
0.98 |
Evaluator_Draft4_Meta_1_No_Callback |
2262.5590625001023 ns/iter |
2354.225943944296 ns/iter |
0.96 |
Evaluator_Draft4_Required_Properties |
1973.1448137777627 ns/iter |
1958.4363021749487 ns/iter |
1.01 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
526.4707000001181 ns/iter |
506.5523000000667 ns/iter |
1.04 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
378.08066462854947 ns/iter |
374.4595045607542 ns/iter |
1.01 |
Evaluator_Draft4_Items_Schema |
6153.938392858192 ns/iter |
6447.270535714113 ns/iter |
0.95 |
Evaluator_Draft4_Nested_Object |
123.39851785713206 ns/iter |
115.28026562501736 ns/iter |
1.07 |
Evaluator_Draft4_Properties_Triad_Optional |
5315.253999999641 ns/iter |
5313.211999998657 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Closed |
4384.45187500065 ns/iter |
4345.387500001152 ns/iter |
1.01 |
Evaluator_Draft4_Properties_Triad_Required |
5415.786607142893 ns/iter |
5359.514285714795 ns/iter |
1.01 |
Evaluator_Draft4_Non_Recursive_Ref |
529.569285714209 ns/iter |
515.6136000000515 ns/iter |
1.03 |
Evaluator_Draft4_Pattern_Properties_True |
8054.739955356232 ns/iter |
8011.633928570103 ns/iter |
1.01 |
Evaluator_Draft4_Ref_To_Single_Property |
382.21121651777725 ns/iter |
383.9508064374438 ns/iter |
1.00 |
Evaluator_Draft4_Additional_Properties_Type |
742.4563616069692 ns/iter |
730.4783482143965 ns/iter |
1.02 |
Evaluator_Draft4_Nested_Oneof |
1050.1523437500994 ns/iter |
1048.3610937502165 ns/iter |
1.00 |
Evaluator_Draft6_Property_Names |
1910.770171359071 ns/iter |
1730.630295205371 ns/iter |
1.10 |
Evaluator_Draft7_If_Then_Else |
501.61230000003343 ns/iter |
520.1974107141691 ns/iter |
0.96 |
Evaluator_2019_09_Unevaluated_Properties |
2164.7718750003264 ns/iter |
2051.3999680798615 ns/iter |
1.06 |
Evaluator_2020_12_Dynamic_Ref |
4677.121600717138 ns/iter |
4762.175138783855 ns/iter |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti [email protected]