Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify non-pure-annotation instructions #17

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Oct 17, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: ba0dc58 Previous: 9e9f8ce Ratio
Compiler_Draft6_AdaptiveCard 2921329916.99998 ns/iter 2758407874.999989 ns/iter 1.06
Evaluator_Draft4_Meta_1_No_Callback 766.5170203794553 ns/iter 740.4889171131022 ns/iter 1.04
Evaluator_Draft4_Required_Properties 952.2569479464186 ns/iter 938.6630234444265 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 153.2885836288824 ns/iter 149.27442055012463 ns/iter 1.03
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 105.23142545433856 ns/iter 102.18730094868049 ns/iter 1.03
Evaluator_Draft4_Items_Schema 2646.025951083527 ns/iter 2619.252911002569 ns/iter 1.01
Evaluator_Draft4_Nested_Object 21.40559747423648 ns/iter 21.21912219293596 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Optional 1322.5821606442119 ns/iter 1251.4511608108955 ns/iter 1.06
Evaluator_Draft4_Properties_Triad_Closed 1010.3192852307585 ns/iter 944.1271918818093 ns/iter 1.07
Evaluator_Draft4_Properties_Triad_Required 1344.4427124730396 ns/iter 1275.8614713892257 ns/iter 1.05
Evaluator_Draft4_Non_Recursive_Ref 224.456286261502 ns/iter 210.82130574462815 ns/iter 1.06
Evaluator_Draft4_Pattern_Properties_True 1412.7822891256264 ns/iter 1327.1941652100352 ns/iter 1.06
Evaluator_Draft4_Ref_To_Single_Property 106.30040491676233 ns/iter 104.0283859862718 ns/iter 1.02
Evaluator_Draft4_Additional_Properties_Type 462.0785111656081 ns/iter 403.7975288265123 ns/iter 1.14
Evaluator_Draft4_Nested_Oneof 366.4476230819193 ns/iter 367.331739095668 ns/iter 1.00
Evaluator_Draft6_Property_Names 822.9471836675749 ns/iter 758.9316175645234 ns/iter 1.08
Evaluator_Draft7_If_Then_Else 168.61031032001253 ns/iter 166.54794209817354 ns/iter 1.01
Evaluator_2019_09_Unevaluated_Properties 621.5996194228543 ns/iter 620.4224501391341 ns/iter 1.00
Evaluator_2020_12_Dynamic_Ref 1466.7450936379207 ns/iter 1385.667870028998 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: ba0dc58 Previous: 9e9f8ce Ratio
Compiler_Draft6_AdaptiveCard 5804374204.999988 ns/iter 5408372566.999958 ns/iter 1.07
Evaluator_Draft4_Meta_1_No_Callback 987.914649697698 ns/iter 980.9211334530019 ns/iter 1.01
Evaluator_Draft4_Required_Properties 1584.1047132033705 ns/iter 1573.9926065352006 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 180.94787074750525 ns/iter 180.24629143005413 ns/iter 1.00
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 130.49691164680985 ns/iter 127.05009477469464 ns/iter 1.03
Evaluator_Draft4_Items_Schema 3506.1669203829106 ns/iter 3586.6251804157337 ns/iter 0.98
Evaluator_Draft4_Nested_Object 30.053643637765063 ns/iter 31.25871137848703 ns/iter 0.96
Evaluator_Draft4_Properties_Triad_Optional 1817.4958888013193 ns/iter 1804.8981879484763 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Closed 1500.3461605485131 ns/iter 1490.6848684379156 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 1869.289468116233 ns/iter 1883.4297117290419 ns/iter 0.99
Evaluator_Draft4_Non_Recursive_Ref 484.97197749335555 ns/iter 464.41267582407403 ns/iter 1.04
Evaluator_Draft4_Pattern_Properties_True 2497.637512462745 ns/iter 2399.656690276318 ns/iter 1.04
Evaluator_Draft4_Ref_To_Single_Property 128.29640305231962 ns/iter 129.98465638544818 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 617.1825320525759 ns/iter 605.2817973584728 ns/iter 1.02
Evaluator_Draft4_Nested_Oneof 471.24826478771394 ns/iter 477.9948175760636 ns/iter 0.99
Evaluator_Draft6_Property_Names 1265.3128208647151 ns/iter 1252.6481350538652 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 204.60976665786131 ns/iter 208.00593112105727 ns/iter 0.98
Evaluator_2019_09_Unevaluated_Properties 731.9027913593487 ns/iter 753.3843200106355 ns/iter 0.97
Evaluator_2020_12_Dynamic_Ref 1830.116555672436 ns/iter 1867.3184987992345 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: ba0dc58 Previous: 9e9f8ce Ratio
Evaluator_2020_12_Dynamic_Ref 1823.0109500401063 ns/iter 1760.6327741082566 ns/iter 1.04
Evaluator_2019_09_Unevaluated_Properties 748.5774972618349 ns/iter 755.4413650617018 ns/iter 0.99
Evaluator_Draft7_If_Then_Else 203.51802147061673 ns/iter 198.83891077011103 ns/iter 1.02
Evaluator_Draft6_Property_Names 1603.7579909633325 ns/iter 1717.468479631883 ns/iter 0.93
Evaluator_Draft4_Meta_1_No_Callback 1140.4577882519832 ns/iter 1075.47521454065 ns/iter 1.06
Evaluator_Draft4_Required_Properties 2322.5832362118254 ns/iter 2317.464646498187 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 191.97112807144595 ns/iter 190.85116352916464 ns/iter 1.01
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 137.56301414488473 ns/iter 141.1606499527997 ns/iter 0.97
Evaluator_Draft4_Items_Schema 3146.884932855722 ns/iter 3021.226225136027 ns/iter 1.04
Evaluator_Draft4_Nested_Object 24.59912557971886 ns/iter 24.29717658077232 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Optional 1749.9162105484752 ns/iter 1715.1752818193706 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Closed 1445.6953563681407 ns/iter 1398.399289486918 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Required 1841.05295584202 ns/iter 1776.2355884371211 ns/iter 1.04
Evaluator_Draft4_Non_Recursive_Ref 473.9555191741637 ns/iter 481.64717879173 ns/iter 0.98
Evaluator_Draft4_Pattern_Properties_True 2346.5946943969443 ns/iter 2301.258079579062 ns/iter 1.02
Evaluator_Draft4_Ref_To_Single_Property 140.08485979911663 ns/iter 147.82135690965336 ns/iter 0.95
Evaluator_Draft4_Additional_Properties_Type 1120.0200682497143 ns/iter 1074.4881207780052 ns/iter 1.04
Evaluator_Draft4_Nested_Oneof 484.388357978948 ns/iter 458.57974009509127 ns/iter 1.06
Compiler_Draft6_AdaptiveCard 5843408006.000004 ns/iter 5839617932.0000105 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Benchmark suite Current: ba0dc58 Previous: 9e9f8ce Ratio
Compiler_Draft6_AdaptiveCard 3713238954.5440674 ns/iter 4575093030.929565 ns/iter 0.81
Evaluator_Draft4_Meta_1_No_Callback 762.9372243399507 ns/iter 864.1936601792431 ns/iter 0.88
Evaluator_Draft4_Required_Properties 1049.225795497348 ns/iter 1181.550063933258 ns/iter 0.89
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 172.19181194596425 ns/iter 189.23189135891997 ns/iter 0.91
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 121.54580979354982 ns/iter 131.17832818901755 ns/iter 0.93
Evaluator_Draft4_Items_Schema 2386.332368585455 ns/iter 2480.7510354442848 ns/iter 0.96
Evaluator_Draft4_Nested_Object 25.258432901258885 ns/iter 26.11115156406681 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Optional 1505.8238812537013 ns/iter 1586.673453223183 ns/iter 0.95
Evaluator_Draft4_Properties_Triad_Closed 1333.4349435285994 ns/iter 1357.4825726357662 ns/iter 0.98
Evaluator_Draft4_Properties_Triad_Required 1617.7198927818076 ns/iter 1673.8366603434483 ns/iter 0.97
Evaluator_Draft4_Non_Recursive_Ref 436.02212050207726 ns/iter 480.5562630766195 ns/iter 0.91
Evaluator_Draft4_Pattern_Properties_True 1990.075439188997 ns/iter 2282.60127346644 ns/iter 0.87
Evaluator_Draft4_Ref_To_Single_Property 119.37040250029055 ns/iter 143.69867597677663 ns/iter 0.83
Evaluator_Draft4_Additional_Properties_Type 492.3704082430225 ns/iter 606.2634140944505 ns/iter 0.81
Evaluator_Draft4_Nested_Oneof 365.2614275376582 ns/iter 507.8458786010742 ns/iter 0.72
Evaluator_Draft6_Property_Names 921.7196891852334 ns/iter 1285.4931867272933 ns/iter 0.72
Evaluator_Draft7_If_Then_Else 184.00870273478503 ns/iter 232.564693499441 ns/iter 0.79
Evaluator_2019_09_Unevaluated_Properties 602.779457407071 ns/iter 868.4072085700236 ns/iter 0.69
Evaluator_2020_12_Dynamic_Ref 1564.7059024713856 ns/iter 1992.6292784635 ns/iter 0.79

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: ba0dc58 Previous: 9e9f8ce Ratio
Compiler_Draft6_AdaptiveCard 10303097700.00008 ns/iter 10154048900.000134 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 2335.589134387246 ns/iter 2270.1192297778966 ns/iter 1.03
Evaluator_Draft4_Required_Properties 1924.9206472503715 ns/iter 1926.5850296708384 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 504.5037500000912 ns/iter 503.2685000001038 ns/iter 1.00
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 375.54416508134665 ns/iter 371.68735811103704 ns/iter 1.01
Evaluator_Draft4_Items_Schema 6563.653571429232 ns/iter 6191.362500000456 ns/iter 1.06
Evaluator_Draft4_Nested_Object 112.25816071426412 ns/iter 116.89521428572951 ns/iter 0.96
Evaluator_Draft4_Properties_Triad_Optional 5300.234999999702 ns/iter 5344.284000000243 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Closed 4443.301874999861 ns/iter 4354.3631250003045 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Required 5375.45899999941 ns/iter 5381.428000000596 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 508.4081999998489 ns/iter 520.3540178570165 ns/iter 0.98
Evaluator_Draft4_Pattern_Properties_True 8049.2578124997335 ns/iter 8411.515127164894 ns/iter 0.96
Evaluator_Draft4_Ref_To_Single_Property 378.174843183081 ns/iter 378.0258610667959 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 725.4910714285603 ns/iter 747.4216964285217 ns/iter 0.97
Evaluator_Draft4_Nested_Oneof 1056.4712499999018 ns/iter 1031.3703125000018 ns/iter 1.02
Evaluator_Draft6_Property_Names 1736.204707898526 ns/iter 1789.2096332231001 ns/iter 0.97
Evaluator_Draft7_If_Then_Else 524.3041000001085 ns/iter 506.7183000001023 ns/iter 1.03
Evaluator_2019_09_Unevaluated_Properties 2092.667500000545 ns/iter 2131.9374999997367 ns/iter 0.98
Evaluator_2020_12_Dynamic_Ref 4777.61701126626 ns/iter 4691.003764289342 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 03841f2 into main Oct 17, 2024
14 checks passed
@jviotti jviotti deleted the annotation-steps branch October 17, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant