(WIP) Parallel archive file operations #186
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhuang
force-pushed
the
parallel
branch
from
464ca29
to
3413fbe
Compare
sourcefrog
reviewed
Sep 1, 2022
|
|
||
| /// Maximum file size that will be combined with others rather than being stored alone. | ||
| const SMALL_FILE_CAP: u64 = 100_000; | ||
| const SMALL_FILE_CAP: u64 = MAX_BLOCK_SIZE as _; |
There was a problem hiding this comment.
I didn't know that as _ phrase, that's neat.
sourcefrog
reviewed
Sep 1, 2022
| } else { | ||
| Ok(()) | ||
| } | ||
| let temp = Alphanumeric.sample_string(&mut thread_rng(), 12); |
There was a problem hiding this comment.
Why this rather than tempfile?
There was a problem hiding this comment.
It's been a while since I made this change—I'm actually not sure what this is for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.