Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace act import deprecation warnings #3050

Merged

Conversation

TheMythologist
Copy link
Contributor

Description

Gets rid of the warning when running tests:

Warning: `ReactDOMTestUtils.act` is deprecated in favor of `React.act`. Import `act` from `react` instead of `react-dom/test-utils`. See https://react.dev/warnings/react-dom-test-utils for more info.

Reference: https://react.dev/warnings/react-dom-test-utils#reactdomtestutilsact-warning

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code

@RichDom2185 RichDom2185 self-requested a review September 22, 2024 16:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10979072522

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.449%

Totals Coverage Status
Change from base Build 10953231367: 0.0%
Covered Lines: 4852
Relevant Lines: 14547

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this and congrats on your first contribution to Source Academy!

@RichDom2185 RichDom2185 merged commit 42c78c0 into source-academy:master Sep 22, 2024
6 checks passed
@TheMythologist TheMythologist deleted the act-import-warning branch September 22, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants