Use DOMPurify
to sanitize and mitigate XSS attacks
#3049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An XSS vulnerability is present in the
Markdown
component, where unsanitized user input is directly passed intodangerouslySetInnerHTML
. For more info, refer to here.Note: The changes in UI test snapshots are merely the order of the
a
tag attributes - they are essentially the same.Type of change
How to test
An example would be entering the text
<img src="" onerror={alert('xss')} />
in the "Module Help Text" of the Admin Panel page when creating a new course. After sanitization, thealert('xss')
command should not be run.Checklist