Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop active_year restriction for search_group #39

Open
Michael-E-Rose opened this issue Oct 5, 2024 · 0 comments
Open

Drop active_year restriction for search_group #39

Michael-E-Rose opened this issue Oct 5, 2024 · 0 comments
Assignees
@Michael-E-Rose
Labels
enhancement New feature or request

Comments

@Michael-E-Rose
Copy link
Collaborator

In search_group_from_sources(), we require the search group to publish in the same journals in two points in time:

  1. The first_year of the original, plus/minus the margin
  2. The active_year of the original, which may be earlier than the comparison_year

The second requirement doesn't make sense and we should drop it.
@Michael-E-Rose Michael-E-Rose added the enhancement New feature or request label Oct 5, 2024
@Michael-E-Rose Michael-E-Rose self-assigned this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michael-E-Rose Michael-E-Rose

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Michael-E-Rose