마이페이지 리팩토링 #269
Merged
마이페이지 리팩토링 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 23, 2023 02:31
added 11 commits
April 24, 2023 20:01
…pt-makers/sopt-android into feature/minjung/230422-mypage
l2hyunwoo
reviewed
Jun 29, 2023
app/src/main/java/org/sopt/official/feature/mypage/signOut/SignOutViewModel.kt
Outdated
Show resolved
Hide resolved
added 2 commits
July 3, 2023 21:05
# Conflicts: # app/src/main/java/org/sopt/official/feature/mypage/MyPageActivity.kt # app/src/main/java/org/sopt/official/feature/mypage/MyPageViewModel.kt # app/src/main/java/org/sopt/official/feature/mypage/signOut/SignOutActivity.kt # app/src/main/java/org/sopt/official/feature/mypage/signOut/SignOutViewModel.kt # app/src/main/java/org/sopt/official/feature/mypage/soptamp/nickName/ChangeNickNameActivity.kt # app/src/main/java/org/sopt/official/feature/mypage/soptamp/nickName/ChangeNickNameViewModel.kt # app/src/main/java/org/sopt/official/feature/mypage/soptamp/sentence/AdjustSentenceActivity.kt # app/src/main/java/org/sopt/official/feature/mypage/soptamp/sentence/AdjustSentenceViewModel.kt # app/src/main/res/values/strings.xml
l2hyunwoo
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
현재 develop 을 머지하면 gradle 에 이상이 생겨서 우선적으로 commit 통한 diff 남기기 용으로 PR 올림
미 진행 상황
-> RxLifecycle / autoDispose 둘중에 하나 선택해서 커스텀이 필요함. 현재의 방식은 아직 검증이 안됨.