Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook server can block #82

Open
dgw opened this issue Jan 26, 2021 · 0 comments
Open

Webhook server can block #82

dgw opened this issue Jan 26, 2021 · 0 comments
Labels

Comments

@dgw
Copy link
Member

dgw commented Jan 26, 2021

We had the webhook server start yielding timeouts when GitHub sent payloads to it.

Unfortunately there was nothing useful in the bot's logs. However, we know that wsgiref is not particularly suited for production use, and there's probably a better ServerAdapter that we could use with Bottle to get things the built-in WSGI reference implementation doesn't offer (higher concurrency, control over and protection from bad requests that never terminate, etc.).

@dgw dgw added the bug label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant