Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel-value method arguments are in the wrong order #130

Open
dgw opened this issue Nov 11, 2023 · 0 comments
Open

Channel-value method arguments are in the wrong order #130

dgw opened this issue Nov 11, 2023 · 0 comments
Labels

Comments

@dgw
Copy link
Member

dgw commented Nov 11, 2023

Back in #65, implementation of the .gh-repo command swapped the channel and key arguments to set_channel_value and friends. Since this plugin consistently uses the incorrect order, this hasn't been a problem; it just looks weird if one examines the DB directly.

Still, this should probably get fixed with some form of automatic migration. We can set a flag using plugin_values to indicate whether the migration has been run, too, now that such a feature exists in core.

@dgw dgw added the bug label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant