New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baremetal target are broken #100

Open

MarcTreySonos opened this issue Jan 28, 2020 · 1 comment

Contributor

MarcTreySonos commented Jan 28, 2020 •

edited

Loading

baremetal targets do not have any sysroot, as a consequence no TARGET_SYSROOT exists for those targets.

this change make the presence of TARGET_SYSROOT mandatory:
https://github.com/snipsco/dinghy/blob/dinghy-test/0.4.21/dinghy-build/src/bindgen_macros.rs#L48

this break the compilation on the cortex-m baremetal target

proposed fix: only add the --sysroot when the env var TARGET_SYSROOT exists

MarcTreySonos assigned Deluvi

Collaborator

kali commented Jan 29, 2020

To be fair, baremetal was never an objective of dinghy. That saif if we can make it work...

jeffwilliamssonos unassigned Deluvi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment