Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debuggablity #116

Open
yue-fred-gao opened this issue Oct 1, 2024 · 0 comments
Open

Improve debuggablity #116

yue-fred-gao opened this issue Oct 1, 2024 · 0 comments

Comments

@yue-fred-gao
Copy link
Contributor

Debuggability at SONIC-VPP SAI layer is poor. If we turn on syncd debug log, it becomes too chatty because that's the level logged by SWSS_LOG_ENTER. And the latter doesn't print arguments. Also, major operations are not logged either.

Proposals

  1. Use SWSS_LOG_INFO. It is not turned on by default and it is above debug level so won't be overwhelmed by debug messages.
  2. All VPP API calls should be logged as INFO with parameters.
  3. Create/set/remove requests from syncd should be logged as INFO with arguments
  4. Other important logs can be added as needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant