Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash-p4] Deprecate order attribute on SaiVal and SaiCounter annotations. #597

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Jun 23, 2024

Since we can now use SAI spec to handle the order of all attributes and APIs, we don't need to explicit specify the order anymore. Hence, removing it from the P4 code.

After all orders are removed, make sai-header locally will not cause any SAI API change as below:

r12f@r12f-dl380:~/code/sonic/DASH/dash-pipeline/SAI/SAI
$ gst
On branch temp
Your branch is up to date with 'origin/temp'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        bm/

nothing added to commit but untracked files present (use "git add" to track)

The order attribute in the SaiTable annotation still needs to be kept, because the lib generation will require it to be present to generate the API initialization code correctly.

@r12f r12f requested a review from marian-pritsak June 23, 2024 17:11
@r12f r12f merged commit 5165875 into sonic-net:main Jun 25, 2024
5 checks passed
@r12f r12f deleted the user/r12f/deprecate-order branch June 25, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants