Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash-p4] Deprecate order annotation on SaiVal, SaiTable and SaiCounter. (pending #594) #596

Closed
wants to merge 3 commits into from

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Jun 23, 2024

Since we can now use SAI spec to handle the order of all attributes and APIs, we don't need to explicit specify the order anymore. Hence, removing it from the P4 code.

After all orders are removed, make sai-header locally will not cause any SAI API change as below:

r12f@r12f-dl380:~/code/sonic/DASH/dash-pipeline/SAI/SAI
$ gst
On branch temp
Your branch is up to date with 'origin/temp'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        bm/

nothing added to commit but untracked files present (use "git add" to track)

@r12f r12f requested a review from marian-pritsak June 23, 2024 15:22
@r12f r12f changed the title [dash-p4] Deprecate order annotation on SaiVal, SaiTable and SaiCounter. [dash-p4] Deprecate order annotation on SaiVal, SaiTable and SaiCounter. (pending #594) Jun 23, 2024
@r12f r12f marked this pull request as draft June 23, 2024 15:22
@r12f r12f force-pushed the user/r12f/deprecate-order branch from b2f3cac to 6126d65 Compare June 23, 2024 15:23
@r12f
Copy link
Collaborator Author

r12f commented Jun 23, 2024

ouch! cannot deprecate until we also have lib fixed..... closing PR.

@r12f r12f closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant