Rename routing group and attributes #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-pritsak
changed the title
marian-pritsak
force-pushed
the
rg-naming
branch
4 times, most recently
from
425ab74
to
47fabb6
Compare
r12f
reviewed
Jun 14, 2024
| @@ -0,0 +1,24 @@ | |||
| !!python/object:utils.sai_spec.sai_api_group.SaiApiGroup | |||
| name: dash_routing_group | |||
There was a problem hiding this comment.
this looks to be unexpected, is this something we forgot to clear?
There was a problem hiding this comment.
Removed the file since this is part of OB routing.
| @@ -10,6 +10,7 @@ api_types: | |||
| - SAI_API_DASH_VNET | |||
| - SAI_API_DASH_OUTBOUND_ROUTING | |||
| - SAI_API_DASH_PA_VALIDATION | |||
| - SAI_API_DASH_TUNNEL | |||
There was a problem hiding this comment.
Regenerated after merging latest master.
| @@ -2,6 +2,26 @@ | |||
| name: dash_outbound_routing | |||
| description: '' | |||
| sai_apis: | |||
| - !!python/object:utils.sai_spec.sai_api.SaiApi | |||
There was a problem hiding this comment.
the order here is also not right, do you mind to help review #577 to avoid this issue?
There was a problem hiding this comment.
Regenerated after merging master.
marian-pritsak
force-pushed
the
rg-naming
branch
from
4d9d7ff
to
a634583
Compare
|
hi @marian-pritsak , do we you mind help rebase the PR, then revert the changes on the SAI spec YAML files and regenerate them again? the new merge behavior should get the ordering problem automatically covered. |
Signed-off-by: Marian Pritsak <[email protected]>
marian-pritsak
force-pushed
the
rg-naming
branch
from
a634583
to
3061a31
Compare
Signed-off-by: Marian Pritsak <[email protected]>
marian-pritsak
force-pushed
the
rg-naming
branch
from
3061a31
to
cd39a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "admin state" to "disabled" and combine it into same API with OB routing entry