Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[submodule] Update SAI submodule to origin/master #431

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

kcudnik
Copy link
Collaborator

@kcudnik kcudnik commented Sep 1, 2023

To include
[test] Refactor saithriftv2 Makefile
opencomputeproject/SAI@4f39bd

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 1, 2023

@chrispsommers please review and if good to go please merge

Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chrispsommers chrispsommers merged commit 3e9d07c into sonic-net:main Sep 1, 2023
4 checks passed
@chrispsommers
Copy link
Collaborator

@kcudnik Does this pave the way to resolve #395 ? In particular, does sai-thrift still require sai meta code inside vendor libsai?

@kcudnik kcudnik deleted the sub branch September 1, 2023 18:04
@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 1, 2023

@kcudnik Does this pave the way to resolve #395 ? In particular, does sai-thrift still require sai meta code inside vendor libsai?

No, currently saimetadata*.o objects are compiled into libsai.so (from dash)

for example: in ~/SAI/test/saithriftv2/Makefile you can se saimetadata lib added when saivs is compiled

 40 ifeq ($(platform),vs)
 41 LIBS = -lthrift -lpthread -lsaivs -lsaimeta -lsaimetadata -lzmq
 42 else
 43 LIBS = -lthrift -lpthread -lsai
 44 endif

so currently that libsai.so from DASH trhift will require that metadata, i have PR almost ready that will simplify this, Makefile DASH/dash-pipeline/SAI/templates/Makefile.j2, and metadata function sai_metadata_get_attr_metadata is required from SAI/meta/sai_rpc_frontend.cpp, since they need to get a attribute type to properly convert sai_attribute to sai_thrift_attribute, and this is manually created file, not sure if any other things could be used in the future in rpc frontend

currently im compiling saimetadata into libsai.so to make it link correctly, but if it's planned to use other libsai than generated from DASH, then we can update SAI/SAI/test/saithriftv2/Makefile to store those metadata objects in that librpcserver.a archive

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 1, 2023

since many different parties are using or will use some part of saimetadata, i propose to make libsaimetadata.so and share it everywhere instead to linking objects in each project, deal later with duplicate references, and make size increase of each file, libsaimetadata.so can be already generated by SAI repo latest commit :)

please take a look at further improvements: #432

clarklee-guizhao added a commit to clarklee-guizhao/DASH that referenced this pull request Dec 3, 2023
* main: (75 commits)
  [dash-SAI] Enable warnings as errors (sonic-net#466)
  [SAI] wrong code generated in libsai sonic-net#415 (sonic-net#463)
  Fix incorrect IP in SONiC-DASH HLD VNET to VNET example. (sonic-net#459)
  DASH pipeline packet flow update proposal. (sonic-net#449)
  [libsai] Add attr name logging when doing get api (sonic-net#451)
  Build libsai deb packages in github workflow (sonic-net#450)
  Add Private Link mapping (sonic-net#327)
  [SAI] Update SAI submodule to the latest origin/master (sonic-net#446)
  [dash] Add libsai-debs target to create libsai debian packages (sonic-net#444)
  update p4 compile dependancy to avoid parallel  docker runs (sonic-net#443)
  [dash] Refactor libsai (sonic-net#438)
  [dash] Update SAI to latest v1.13 (sonic-net#435)
  [dash-pipeline] Refactor Makefiles (sonic-net#432)
  Remove ACL tags from BM (sonic-net#425)
  [submodule] Update SAI submodule to origin/master (sonic-net#431)
  [sai-api-gen] Write files only when changes are detected (sonic-net#429)
  Adds SAI_ROUTE_ENTRY_ATTR_PACKET_ACTION api to dash_underlay_routing (sonic-net#422)
  [SAI] Add missing check for api initialized
  [SAI] Print oids in hex form
  [SAI] Change asserts to return error codes and add missing switch api
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants