[SAI] Move constructor to sai_api_initialize #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For future passing parameters via service method table
|
|
||
| // TODO below apis are extern of internal implementation | ||
| // they should not be used by extern, but obtained via | ||
| // sai_api_query function, FIXME |
There was a problem hiding this comment.
Could you add an issue to ensure tracking? Thanks.
chrispsommers
approved these changes
Aug 1, 2023
|
please merge if is ok, i dont have permissions here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For future passing parameters via service method table
Fixes #411
@lguohan @marian-pritsak @Pterosaur @chrispsommers please review