Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[submodule] Update SAI submodule to origin/master #412

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

kcudnik
Copy link
Collaborator

@kcudnik kcudnik commented Aug 1, 2023

Set SAI repo to latest one

@kcudnik
Copy link
Collaborator Author

kcudnik commented Aug 1, 2023

@lguohan @marian-pritsak @Pterosaur @chrispsommers please review

@lguohan can you give me some privileges in this repo so i could add reviewers during PR creation, currently i can't do that

Comment on lines 179 to 182
# hack - remove scripts which cause Git ownership failures in CI pipelines
# We don't need them, they're to check that SAI headers didn't experience enum changes etc.
sed -ie '/checkenumlock.sh/d' SAI/SAI/meta/Makefile
sed -ie '/checkancestry.sh/d' SAI/SAI/meta/Makefile
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hack is no longer needed, i updated SAI/meta opencomputeproject/SAI#1833 since size.sh have similar issue, but it must generate size file

Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrispsommers chrispsommers merged commit 75de795 into sonic-net:main Aug 2, 2023
3 checks passed
@kcudnik kcudnik deleted the saisub branch August 2, 2023 18:41
@kcudnik
Copy link
Collaborator Author

kcudnik commented Aug 2, 2023

this points to 7a45648e928836722df241dfe01c57e02876d5c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants