Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAI move to Master (Intel) #388

Closed
KrisNey-MSFT opened this issue Jun 8, 2023 · 5 comments · Fixed by #398
Closed

SAI move to Master (Intel) #388

KrisNey-MSFT opened this issue Jun 8, 2023 · 5 comments · Fixed by #398
Assignees
@reshmaintel
Labels
help wanted Extra attention is needed

Comments

@KrisNey-MSFT
Copy link
Collaborator

SAI needs to be moved to Master; this is still being worked at Intel.
An OCP SAI fix is needed and from there they can move the pointer, which is needed for DASH (for VXLAN).
(request from Vincent)
@KrisNey-MSFT KrisNey-MSFT added the help wanted Extra attention is needed label Jun 8, 2023
@KrisNey-MSFT
Copy link
Collaborator Author

https://github.com/opencomputeproject/SAI/pull/1755/files

opencomputeproject/SAI#1573

Sent email to @richardyu-ms internally

@KrisNey-MSFT
Copy link
Collaborator Author

KrisNey-MSFT commented Jun 28, 2023 •
edited
Loading

Need to move pointer from DASH to SAI instead of the private fork, @reshmaintel will do this.

New PR Merged: https://github.com/opencomputeproject/SAI/pull/1813

@ravi861
Copy link

ravi861 commented Jul 10, 2023

#398 should resolve this issue.

@chrispsommers chrispsommers mentioned this issue Jul 12, 2023
Merged
@KrisNey-MSFT
Copy link
Collaborator Author

hi guys, sorry I'm late on this one... is it okay to close?
@kcudnik @reshmaintel

@chrispsommers
Copy link
Collaborator

Yup, we've moved to master twice since this was opened, just this morning it was updated again by @kcudnik and I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reshmaintel reshmaintel

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update SAI refpoint to OCP SAI ravi861/DASH
4 participants
@ravi861 @KrisNey-MSFT @chrispsommers @reshmaintel