From d2fad865b25dc40c44221dc6e7e84acfaa87a22a Mon Sep 17 00:00:00 2001 From: Eric Eisenhart Date: Thu, 16 May 2024 13:28:45 -0700 Subject: [PATCH] bugfix: Don't delete old tags aka: remove some debug stuff I had earlier --- src/sonic/netbox_zabbix/netbox_zabbix.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/sonic/netbox_zabbix/netbox_zabbix.py b/src/sonic/netbox_zabbix/netbox_zabbix.py index d198f62..adaa161 100644 --- a/src/sonic/netbox_zabbix/netbox_zabbix.py +++ b/src/sonic/netbox_zabbix/netbox_zabbix.py @@ -123,9 +123,11 @@ def copy_netbox_maint_update_info_to_zabbix_tags(self, netbox_servers, zabbix_se if netbox_servers[name].custom_fields['update_group']: self.log.info(f"Adding update_group to zabbix for {name}") - if zabbix_servers[name]['tags']: + if 'tags' in zabbix_servers[name]: tags = zabbix_servers[name]['tags'] + self.log.info(f"DEBUG: tags: {pformat(tags)}") new_tags = [item for item in tags if item['tag'] != 'netbox-update-group'] + self.log.info(f"DEBUG: new_tags(1): {pformat(new_tags)}") else: new_tags = [] @@ -133,13 +135,12 @@ def copy_netbox_maint_update_info_to_zabbix_tags(self, netbox_servers, zabbix_se 'tag': 'netbox-update-group', 'value': netbox_servers[name].custom_fields['update_group'], }) + + self.log.info(f"DEBUG: new_tags(2): {pformat(new_tags)}") + response = self.zabbix.api.host.update( hostid=zabbix_servers[name]['hostid'], -# tags=new_tags, - tags={ - 'tag': 'netbox-update-group', - 'value': netbox_servers[name].custom_fields['update_group'], - }, + tags=new_tags, ) self.log.info(f"DEBUG: response: {pformat(response)}") else: