Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand kubernetes e2e default resources to include reusable validation of application/deletion #9980

Open
sheidkamp opened this issue Aug 30, 2024 · 0 comments

Comments

@sheidkamp
Copy link
Contributor

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.

Many of our test flakes seem to be caused by resources not being ready because we are skipping the validation of their deployment, especially for the Curl pod.

We have defaults defined here and code that uses them here. We should be using these defaults and create reusable code for application and deletion of these resources

Describe the solution you'd like

An approach has been started here: #9979

  • Remove curl pods defined in the individual tests in favor of the default implementations
  • Apply and delete these pods using common code

The common functions will require access to components of the suite - as implemented in the PR linked above, they require:

  • the test installation
  • the context
  • Assert()

instead of passing these individually, a CommonTestSuite interface has been created:

type CommonTestSuite interface {
	TestInstallation() *e2e.TestInstallation
	Ctx() context.Context
	Assert() *assert.Assertions
}

that can be passed to these functions. This requires adding TestInstallation() and Ctx() methods to each individual suite that uses these common functions, but long term I think that is cleaner than passing the individual components as needed.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant