Tree shaking css #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
purgecss
branch
2 times, most recently
from
7acd21a
to
d9e9f6c
Compare
|
This does not work yet. Maybe we need to use postcss-purgecss plugin instead |
|
Yeah I'm not clear how these CSS cleaners work. The thing is the Realworld Demo uses pre-existing CSS files that aren't being included in the JS so I'm not sure a bundler has enough knowledge. |
|
I have not been able to make this work. But if we do, that would be a huge benefit! We might make a wrapper plugin specifically for Solid with the settings that we are sure would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #3