Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo app to support latest version #177

Merged
merged 16 commits into from
Apr 12, 2024
Merged

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Apr 3, 2024

Describe your changes

  • adjust setting up account instances by adding chainId and cairoVersion in StarknetAccount constructor
  • update execute to executeV3 while transferring tokens

Linked issues

Closes #176

Breaking changes

  • This issue contains breaking changes

@DelevoXDG
Copy link
Collaborator

Let's not mark this PR as containing breaking changes, as we only change the demo and not the SDK itself

@franciszekjob franciszekjob marked this pull request as ready for review April 3, 2024 13:58
README.md Outdated Show resolved Hide resolved
franciszekjob and others added 2 commits April 5, 2024 15:52
Copy link
Collaborator

@DelevoXDG DelevoXDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciszekjob franciszekjob merged commit 5aed9f9 into main Apr 12, 2024
1 check passed
@franciszekjob franciszekjob deleted the chore/update-demo-app branch April 12, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update demo app
2 participants