Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Small improvements #79

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Small improvements #79

wants to merge 5 commits into from

Conversation

a2
Copy link

@a2 a2 commented Oct 21, 2014

  • Update result dictionary keys
  • Don't delete keychain items when saving; update if possible

SecItemDelete is available starting on OS X 10.6; surely that's fine.
Previously, the existing keychain item was always deleted and then re-created.
status = SecKeychainItemDelete((SecKeychainItemRef)result);
CFRelease(result);
}
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't see that. I'll revert the commit.

@a2
Copy link
Author

a2 commented Oct 21, 2014

Considered adding a commit updating the code to use keyed subscripting. Would that be useful or unnecessary?

@soffes
Copy link
Owner

soffes commented Mar 11, 2016

I'm a fan of the keys improvement. Is don't delete okay in light of 6dd2718? cc @calebd

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants