diff --git a/registry/registry-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/KubernetesRegistry.java b/registry/registry-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/KubernetesRegistry.java index e9f957416..90ff2ccda 100644 --- a/registry/registry-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/KubernetesRegistry.java +++ b/registry/registry-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/KubernetesRegistry.java @@ -230,11 +230,9 @@ public void batchUnSubscribe(List configs) { public void destroy() { // unRegister provider providerInstances.forEach((k, v) -> unRegister(k)); - providerInstances.clear(); // unRegister consumer consumerListeners.forEach((k, v) -> unSubscribe(k)); - consumerListeners.clear(); // close kubernetes client kubernetesClient.close(); diff --git a/registry/registry-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/util/KubernetesConfigUtils.java b/registry/registry-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/util/KubernetesConfigUtils.java index 32002fc41..3abc71b5f 100644 --- a/registry/registry-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/util/KubernetesConfigUtils.java +++ b/registry/registry-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/util/KubernetesConfigUtils.java @@ -65,6 +65,7 @@ public static Config buildKubernetesConfig(RegistryConfig registryConfig) { private static String buildMasterUrl(RegistryConfig registryConfig) { String address = registryConfig.getAddress(); + // TODO maybe use Config property if (StringUtils.isNotBlank(address)) { return "http://" + address; }