Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie package dependency vulnerability that was fixed in version [email protected] but socket.io use [email protected] #5222

Open
daeteck opened this issue Nov 5, 2024 · 0 comments
Labels
to triage Waiting to be triaged by a member of the team

Comments

@daeteck
Copy link

daeteck commented Nov 5, 2024

Impact
The cookie name could be used to set other fields of the cookie, resulting in an unexpected cookie value. For example, serialize("userName=<script>alert('XSS3')</script>; Max-Age=2592000; a", value) would result in "userName=<script>alert('XSS3')</script>; Max-Age=2592000; a=test", setting userName cookie to <script> and ignoring value.

A similar escape can be used for path and domain, which could be abused to alter other fields of the cookie.

Patches
Upgrade to 0.7.0, which updates the validation for name, path, and domain.

Workarounds
Avoid passing untrusted or arbitrary values for these fields, ensure they are set by the application instead of user input.

References
jshttp/cookie#167

@daeteck daeteck added the to triage Waiting to be triaged by a member of the team label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to triage Waiting to be triaged by a member of the team
Projects
None yet
Development

No branches or pull requests

1 participant