Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: has two connect on connection callback #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtdxc
Copy link

@mtdxc mtdxc commented Aug 3, 2021

i have woked SioChatDemo with socket.io chatroom example
and found if i connect with default namespace just for one client, node server will got two connection callback.
it sounds like default namespace don't need to call send connection packet, server will handle it.
and then i make a fixed.

here i node.js server code, just add a console.log at connection callback..


io.on('connection', (socket) => {
  let addedUser = false;
  **console.log("new connection");**
  // when the client emits 'new message', this listens and executes
  socket.on('new message', (data) => {
    // we tell the client to execute 'new message'
    socket.broadcast.emit('new message', {
      username: socket.username,
      message: data
    });
  });
  ...

io.on('connection', (socket) => {
  let addedUser = false;
  console.log("new connection");
  // when the client emits 'new message', this listens and executes
  socket.on('new message', (data) => {
    // we tell the client to execute 'new message'
    socket.broadcast.emit('new message', {
      username: socket.username,
      message: data
    });
  });
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant