Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated AppStatus output #677

Open
andrew-stevenson-sociomantic opened this issue Feb 6, 2019 · 0 comments
Open

Truncated AppStatus output #677

andrew-stevenson-sociomantic opened this issue Feb 6, 2019 · 0 comments

Comments

@andrew-stevenson-sociomantic
Copy link
Contributor

v4.3.5 introduced a regression (well 2814d46 to be precise) such that the console output of my application, provided by AppStatus (https://github.com/sociomantic-tsunami/ocean/blob/2814d46b313a3be7c96eacd470242f94d72bab3c/src/ocean/io/console/AppStatus.d), is truncated at the 80th column.

I have a workaround but I suspect the correct fix to the regression (i.e. restoring the old behaviour but completely untested) is changing the 80 to 0 here:

int terminal_columns = 80)

This may however break the intention of 2300aa9

Without looking to hard I would think a correct design would be to default to querying the terminal (the behaviour you get by using 0 for terminal width). If there is no terminal (i.e.

ioctl(0, TIOCGWINSZ, &max);
fails) then a flag is kept indicating no output should be produced until the application prods AppStatus in the future (i.e. when AppStatus is connected to a socket). At that point the App provides the desired width, or again 0 to query the Terminal again, now there presumably is one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants