Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Proxy from Yesod Classy Prelude? #187

Open
MaxGabriel opened this issue Jan 28, 2020 · 2 comments
Open

Remove Proxy from Yesod Classy Prelude? #187

MaxGabriel opened this issue Jan 28, 2020 · 2 comments

Comments

@MaxGabriel
Copy link
Collaborator

Currently classy-prelude-yesod exports Proxy from https://hackage.haskell.org/package/http-conduit-2.3.7.3/docs/Network-HTTP-Client-Conduit.html#t:Proxy.

However, this conflicts in name with the fairly common Data.Proxy.Proxy. You also get a fairly confusing type error if you try to use the common (Proxy :: Proxy X) idiom with just the classy-prelude Proxy in scope:

src/Mercury/Purpose/Types.hs:74:69-77: error:
    • Expected kind ‘* -> *’, but ‘Proxy’ has kind ‘*’
    • In an expression type signature: Proxy Int
      In the first argument of ‘getTypeScriptDeclarations’, namely
        ‘(Proxy :: Proxy Int)’
      In the expression: getTypeScriptDeclarations (Proxy :: Proxy Int)
   |
74 |   getTypeScriptDeclarations _ = getTypeScriptDeclarations (Proxy :: Proxy Int) -- PurposeProxy.PurposeCodeData

Thoughts on removing that export from classy-prelude?

@snoyberg
Copy link
Owner

snoyberg commented Jan 28, 2020 via email

@BebeSparkelSparkel
Copy link
Collaborator

@MaxGabriel Were you going to create a pr for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants