Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing if we do not use InstallReferrer library in consumer application #682

Open
Prithuld opened this issue Apr 4, 2024 · 6 comments
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.

Comments

@Prithuld
Copy link

Prithuld commented Apr 4, 2024

Describe the bug
Our app is crashing and it needs InstallReferrer library to be added in our application to get it fixed.

To Reproduce
Aleady background is mentioned #647

Expected behavior
We do not want to add any additional library in our application to support snowplow, ideally snowplow should fix it by passing the dependency transitively .
We just want to use snowplow library (no additional one to support it 😞 )

Screenshots
Mentioned #647

Device informatoin (please complete the following information):

  • Device: [e.g. Pixel XL2]
  • OS: [e.g. Android 9]
  • Browser [e.g. chrome, firefox]
  • Version [e.g. 84]
@Prithuld Prithuld added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Apr 4, 2024
@miike
Copy link

miike commented Apr 4, 2024

@Prithuld Is this the same issue described in #647 or are you reporting a different issue? If so I will close this.

@Prithuld
Copy link
Author

Prithuld commented Apr 4, 2024

No,actually we do not prefer to implement InstallReferrer in our application, are you going to provide required dependency transitively?

@matus-tomlein
Copy link
Contributor

Hi @Prithuld, thanks for raising this! The tracker does not have a transitive dependency on the InstallReferrer because we wanted to let users who don't wish to track the information provided by the InstallReferrer to use the tracker without any extra dependencies. Tracking the referrer information from the InstallReferrer library is an optional feature that is only enabled in case the dependency is available in the app. Does that make sense?

@Prithuld
Copy link
Author

Prithuld commented Apr 4, 2024

ok thanks.. what will be the impact if we do not implement InstallReferrer ? which feature we will loose?

@matus-tomlein
Copy link
Contributor

@Prithuld the impact is the referrer_details entity that the tracker adds to the application install event based on the information from the InstallReferrer library – here is the documentation for it.

@Prithuld
Copy link
Author

Prithuld commented Apr 4, 2024

Gotcha, it seems this information we need but how do you feel to include it? I mean you can take user input to track information in configuration (in may be Snowplow object creation ,not sure may be)without removing the library. Ideal case consumer application does not want to use two library for same purpose. We can make this feature optional different way I feel , do you think excluding the library is only option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Development

No branches or pull requests

3 participants