Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-422709 Make jira_close workflow use gajira-transition #827

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfc-gh-kzaveri
Copy link
Contributor

@sfc-gh-kzaveri sfc-gh-kzaveri commented Aug 12, 2021

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #422709

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

Uses a modified version of gajira-transition to close issues.

@codecov-commenter
Copy link

Codecov Report

Merging #827 (61a5207) into master (740d9b9) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
+ Coverage   82.50%   82.55%   +0.05%     
==========================================
  Files          58       58              
  Lines        7680     7680              
  Branches     1164     1164              
==========================================
+ Hits         6336     6340       +4     
+ Misses       1018     1015       -3     
+ Partials      326      325       -1     
Impacted Files Coverage Δ
src/snowflake/connector/ocsp_snowflake.py 71.63% <0.00%> (+0.33%) ⬆️
src/snowflake/connector/errors.py 90.50% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740d9b9...61a5207. Read the comment docs.

Comment on lines +43 to +64
"comment": [
{
"add": {
"body" : {
"version": 1,
"type": "doc",
"content": [
{
"type": "paragraph",
"content": [
{
"type": "text",
"text": "Closed on GitHub"
}
]
}
]
}
}
}
]
}'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to figure out how to do this - see https://developer.atlassian.com/cloud/jira/platform/apis/document/structure/

@sfc-gh-kzaveri sfc-gh-kzaveri marked this pull request as ready for review August 13, 2021 14:53
@sfc-gh-mkeller sfc-gh-mkeller marked this pull request as draft August 20, 2021 19:04
@sfc-gh-mkeller
Copy link
Collaborator

Putting this back to being a draft, we need atlassian/gajira-transition#23 resolved before we could merge this

@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants