-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting destreamer working on M1/M2 macs + using all latest packages + sharepoint videos. Tested + working. #489
Comments
I get a "No matching version found for @types/puppeteer@^19.11.1" when running |
what my error is
then i run |
remove "@types/" bit leaving only "puppeteer" from the packages.json file from both the sections, devDependencies and dependencies. Please see if that works. |
does it fix it? If not, did you follow all the steps, exactly, like step #6 ?!? |
yes , i fix it |
That worked, cheers. |
I've just managed to get this working, and that too on my M1 mac running macOS Ventura 13.4.1.
I'll try to lay out what I've done to fix and hopefully can create a pull request and fix this too for all.
These are macOS specific instructions, though you can ignore macOS bits and make it work for other OS's.
Run these two commands. (it'll set the right flags for macOS SIP/watchdog/whatever)
change "@types/puppeteer" : "5.5.0",
to "puppeteer" : "^19.11.1",
change "puppeteer" : "5.5.0",
to "puppeteer" : "^19.11.1",
edit the tsconfig.json file to add a line after "sourceMap"...
"noImplicitAny": false,
now run npm install
(going for gold!) We'll also update all the node packages and their versions. Run npm update --save
at this stage you can now try and run npm run build
You'll get a few errors!
First kind...
few of these... src/LoginModules.ts:14:20 - error TS2503: Cannot find namespace 'puppeteer'.
and few of these... src/TokenCache.ts:60:20 - error TS2503: Cannot find namespace 'puppeteer'.
to Fix this, just edit these two files and change
this line => import puppeteer from 'puppeteer';
to this => import * as puppeteer from 'puppeteer';
running npm run build again, gives you one more error...
src/TokenCache.ts:99:24 - error TS2339: Property 'waitFor' does not exist on type 'Page'.
edit src/TokenCache.ts file line 99 and change waitFor to waitForTimeout (see: [Bug]: TypeError: page.waitFor is not a function when using pupeteer puppeteer/puppeteer#9762)
Finally you are ready to build. npm run build will work.
I've successfully tested today downloading two recordings. 😄
Originally posted by @hakt0-r in #487 (comment)
The text was updated successfully, but these errors were encountered: